Skip to content

Source user object id directly instead of with graph#11531

Merged
benbp merged 1 commit intoAzure:mainfrom
benbp:benbp/deploy-no-graph
Aug 6, 2025
Merged

Source user object id directly instead of with graph#11531
benbp merged 1 commit intoAzure:mainfrom
benbp:benbp/deploy-no-graph

Conversation

@benbp
Copy link
Member

@benbp benbp commented Aug 5, 2025

Source user object id directly instead of with graph

Copilot AI review requested due to automatic review settings August 5, 2025 20:14
@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label Aug 5, 2025
@benbp benbp self-assigned this Aug 5, 2025
@benbp benbp requested a review from a team as a code owner August 5, 2025 20:14
@benbp benbp requested review from mikeharder and weshaggard August 5, 2025 20:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the user object ID retrieval logic to source it directly from the Azure context instead of using Azure AD Graph API calls. The change simplifies the code by eliminating multiple fallback attempts to lookup users via email and UserPrincipalName.

  • Replaces Graph API user lookups with direct extraction from Azure context ExtendedProperties
  • Removes fallback logic for corp tenant and TME tenant user ID lookups
  • Simplifies error handling by consolidating multiple null checks

@benbp benbp force-pushed the benbp/deploy-no-graph branch from 9b92452 to 3b416a2 Compare August 5, 2025 20:15
@benbp benbp moved this from 🤔 Triage to 🔬 Dev in PR in Azure SDK EngSys 📆🎇 Aug 5, 2025
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

@benbp benbp force-pushed the benbp/deploy-no-graph branch from 3b416a2 to 5827e7a Compare August 5, 2025 21:31
@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

azure-sdk added a commit to Azure/azure-sdk-for-js that referenced this pull request Aug 6, 2025
Sync eng/common directory with azure-sdk-tools for PR
Azure/azure-sdk-tools#11531 See [eng/common
workflow](https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/README.md#workflow)

Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
@benbp benbp merged commit e06e492 into Azure:main Aug 6, 2025
7 checks passed
@benbp benbp deleted the benbp/deploy-no-graph branch August 6, 2025 19:44
@kurtzeborn kurtzeborn moved this from 🔬 Dev in PR to 🎊 Closed in Azure SDK EngSys 📆🎇 Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants